search

lazarusllong / sqldeveloper-package

Oracle SQL Developer Debian package builder
https://lazarusllong.github.io/sqldeveloper-package/
2 stars 3 forks source link

Doesn't work with latest SQL Developer version #6

Open icolquhoun opened 3 years ago

icolquhoun commented 3 years ago

Things go along fine until I get this error:

Reorganizing the work directory "/tmp/tmp.B3GMfjYGQT/sqldeveloper-20.4.0.379.2205" to generate FSH compliant package(s) ... ln: failed to create symbolic link '/tmp/tmp.B3GMfjYGQT/sqldeveloper-20.4.0.379.2205/usr/lib/x86_64-linux-gnu/sqldeveloper/20.4.0.379.2205/.5.6': File exists

Forage commented 3 years ago

I can confirm the issue occurring. To be a bit more specific: sqldeveloper 20.4.1.407.0006

abo@ABO-TP:~/Downloads$ make-sqldeveloper-package sqldeveloper-20.4.1.407.0006-no-jre.zip 
make-sqldeveloper-package 0.5.4 Copyright © 2009-2018 Lazarus Long
Debian package builder and installer for Oracle SQL Developer

Environment variables are:
    DEBFULLNAME=""
    DEBEMAIL="abo@ABO-TP"
Active flags are: (none)
Creating work directory "/tmp/tmp.LFnXDSrMnH" ... done!
Creating build installation directory "/tmp/tmp.LFnXDSrMnH/sqldeveloper/usr/share" ... done!
Extracting upstream archive "sqldeveloper-20.4.1.407.0006-no-jre.zip" to "/tmp/tmp.LFnXDSrMnH/sqldeveloper/usr/share" ... done!
Obtaining upstream full version: "20.4.1.407.0006" ... done!
Renaming the work directory "/tmp/tmp.LFnXDSrMnH/sqldeveloper" to "/tmp/tmp.LFnXDSrMnH/sqldeveloper-20.4.1.407.0006" ... done!
Reorganizing the work directory "/tmp/tmp.LFnXDSrMnH/sqldeveloper-20.4.1.407.0006" to generate FSH compliant package(s) ... /usr/bin/make-sqldeveloper-package: 654: [: Illegal number: libglass
/usr/bin/make-sqldeveloper-package: 656: [: Illegal number: libglass
ln: failed to create symbolic link '/tmp/tmp.LFnXDSrMnH/sqldeveloper-20.4.1.407.0006/usr/lib/x86_64-linux-gnu/sqldeveloper/20.4.1.407.0006/.l.i.b.g.l.a.s.s': File exists

The previous version (20.2.0.175.1842) does work as expected and compared to this version many more *.so files have been included (in modules/javafx/linux-x64/lib) with not all of them having a version in the file name. Something which is assumed in https://github.com/lazarusllong/sqldeveloper-package/blob/3252aede67af47b84f27056c1fc9f9eed96c1bba/make-sqldeveloper-package#L650. But I suppose it only needs to be extracted from libjnidispatch-422.so.

Forage commented 2 years ago

The issue remains in 21.4.3.063.0100. If you don't need the shared library package (libjnidispatch-20.2.0.175.1842_4.2.2+0.5.4-1_amd64.deb) you can build the package with the -s argument without a problem:

make-sqldeveloper-package -s sqldeveloper-21.4.3.063.0100-no-jre.zip

Note that there's a bug (#8) when building the package without the shared library package though. When running sqldeveloper afterwards it will fail with the error /usr/bin/sqldeveloper.21.4.3.063.0100: 160: Syntax error: Unterminated quoted string. Edit line 78 of that file by adding a quote after LD_LIBRARY_PATH= (fixed with #7).