Eslint configuration is invalid

CharidimosTzedakis commented 2 months ago

Describe the bug

As I open the project in an editor, ESlint reports configuration error.

Possible solution: The .eslintrc.cjs file exclude prop should be renamed to ignorePatterns or if preferred better an .eslintignore file could be created.

Reproduction

No response

Steps to reproduce

Open project in an editor (e.g. Webstorm or vs-code) which has eslint configured and enabled.

System Info

System:
    OS: Linux 6.10 EndeavourOS
    CPU: (16) x64 AMD Ryzen 7 5800X3D 8-Core Processor
    Memory: 3.74 GB / 15.54 GB
    Container: Yes
    Shell: 5.2.32 - /bin/bash
  npmPackages:
    @babel/eslint-parser: ^7.24.5 => 7.24.5 
    @babel/plugin-syntax-import-assertions: ^7.24.1 => 7.24.1 
    @babel/preset-react: ^7.24.1 => 7.24.1 
    @lazarv/react-server: link:packages/react-server => 0.0.0 
    @types/node: ^20.12.12 => 20.12.12 
    @typescript-eslint/eslint-plugin: ^7.10.0 => 7.10.0 
    @typescript-eslint/parser: ^7.10.0 => 7.10.0 
    eslint: ^8.57.0 => 8.57.0 
    eslint-config-prettier: ^9.1.0 => 9.1.0 
    eslint-plugin-jsx-a11y: ^6.8.0 => 6.8.0 
    eslint-plugin-react: ^7.34.1 => 7.34.1 
    eslint-plugin-simple-import-sort: ^12.1.0 => 12.1.0 
    prettier: ^3.2.5 => 3.2.5 
    typescript: ^5.4.5 => 5.4.5 
    typescript-plugin-css-modules: ^5.1.0 => 5.1.0

Used Package Manager

pnpm

Logs

vs_codium_eslint_error webstorm_eslint_error

Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[x] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion.
[X] The provided reproduction is a minimal reproducible example of the bug.

lazarv commented 2 months ago

Hi @CharidimosTzedakis! Could you please try this out using the latest version from the upstream repository? I updated this part already and that change should fix this issue.

CharidimosTzedakis commented 2 months ago

Confirmed to work :pray: - hadn't sync the fork thats why i didn't see it - will keep in mind to keep the fork synced

github-actions[bot] commented 1 month ago

This issue has been locked since it has been closed for more than 30 days.

If you have found a concrete bug or regression related to it, please open a new bug report with a reproduction against the latest version of @lazarv/react-server. If you have any other comments you should create a new discussion.

lazarv / react-server