lazd / gulp-karma

Karma plugin for gulp
MIT License
75 stars 36 forks source link

Work with karma 0.11 #15

Closed clkao closed 10 years ago

lazd commented 10 years ago

The latest stable version of karma is 10.9: https://www.npmjs.org/package/karma

This package tracks stable releases of karma.

Also: never use > when specifying dependency versions unless you restrict the version to be < the next major version. When major versions with breaking changes come out, your build will mysteriously break. With peerDependencies, its a fine line, because you want them to be lenient to avoid conflicts, but at the same time don't want to auto-install non-stable versions of packages if they're not directly specified as a dependency of the root package.

clkao commented 10 years ago

I am aware of the > issue, but this seems to be the common practice for karma modules:

npm ERR! peerinvalid Peer karma-chai@0.0.2 wants karma@>=0.9
npm ERR! peerinvalid Peer karma-live-preprocessor@0.2.2 wants karma@>=0.10
npm ERR! peerinvalid Peer karma-mocha@0.1.1 wants karma@>=0.9
npm ERR! peerinvalid Peer karma-ng-scenario@0.1.0 wants karma@>=0.9
npm ERR! peerinvalid Peer karma-phantomjs-launcher@0.1.2 wants karma@>=0.9

can we do "karma": ">=0.10.0 <0.12.0" so projects requiring karma 0.11 can at least use this at their own risk?

lazd commented 10 years ago

@clkao, if we're sure everything works in Karma >= 0.9 <0.12, then I'll accept a PR that sets that as the peer dependency.

clkao commented 10 years ago

I am not sure about 0.9. I am using 0.11 myself and it works fine. Will you take ">=0.10 < 0.12" ?