search

lazd / gulp-karma

Karma plugin for gulp
MIT License
75 stars 36 forks source link

Give option to not override files #18

Open dluxemburg opened 10 years ago

dluxemburg commented 10 years ago

This is useful for situations in which overriding Karma's file list will break a test suite (such as when using RequireJS and the no-include file option). It's a minimal change that has no impact on behavior when the feature isn't opted in to.

lazd commented 10 years ago

Related to #9.

dluxemburg commented 10 years ago

Okay, will comment there. Any chance of landing this though as a simple fix? Seems like a number of users are affected.

blittle commented 10 years ago

:+1: Would love to see this merged!

sfarthin commented 10 years ago

:+1:

nmccready commented 10 years ago

:+1: .... bueller

lazd commented 10 years ago

@blittle @nmccready @sfarthin, stay tuned over at https://github.com/karma-runner/karma/issues/1037 for a better solution for gulp + karma integration.

nmccready commented 10 years ago

thank you

nmccready commented 10 years ago

I forked it for the time being with the @dluxemburg changes merged to my master

lazd commented 10 years ago

@nmccready, you can target specific commit hashes in your package.json and use forks/branches, btw: https://www.npmjs.org/doc/json.html#Git-URLs-as-Dependencies

nmccready commented 10 years ago

Oh cool, well for the time-being this is safer for my work. We need to stand up a node repository, and a private bower repo.

nmccready commented 10 years ago

Any updates on this?