lazd / gulp-karma

Karma plugin for gulp
MIT License
75 stars 36 forks source link

Update `gulp-util`. #22

Closed ryan-roemer closed 10 years ago

ryan-roemer commented 10 years ago

This update was originally integrated in https://github.com/lazd/gulp-karma/pull/19, but didn't wind up in master. The issue is current master has:

stream.emit('error', new gutil.PluginError('gulp-karma', 'karma exited with code ' + code));

But the version of gulp-utils doesn't have PluginError, yielding:

/PATH/TO/REPO/node_modules/gulp-karma/index.js:57
        stream.emit('error', new gutil.PluginError('gulp-karma', 'karma exited
                             ^
TypeError: undefined is not a function
    at done (/PATH/TO/REPO/node_modules/gulp-karma/index.js:57:30)
    at ChildProcess.<anonymous> (/PATH/TO/REPO/node_modules/gulp-karma/index.js:83:7)
    at ChildProcess.EventEmitter.emit (events.js:98:17)
    at Process.ChildProcess._handle.onexit (child_process.js:797:12)

on a test error...

lazd commented 10 years ago

@ryan-roemer, thanks for the fix!