search

lazd / gulp-karma

Karma plugin for gulp
MIT License
75 stars 36 forks source link

Upgrading to support newer karma versions. #45

Open gautema opened 9 years ago

gautema commented 9 years ago

I have upgraded all dependencies and fixed so it don't get deprecated messages from karma. And will work even in next karma version.

kevcenteno commented 9 years ago

@lazd Any way we can get this merged and pushed to npm?

lazd commented 9 years ago

@kevcenteno honestly, this plugin needs to be deprecated. See #43.

The way things are done here is error prone, not gulpish, and just quite a bit hacky. When I built this, gulp was young and I needed a way to use it with Karma. Since then, the Karma team has fixed many problems I was working around here (the whole notion of background.js) and come up with a recommended way to use Karma with gulp.

Can you please take a look at the recommended approach and let me know what shortcomings are causing you to still use gulp-karma? We can work with the Karma team to find a way around them.

kevcenteno commented 9 years ago

Thank you for the quick response, @lazd.

The main thing I like this gulp task is that I can use wiredep to load my dependencies (whether they're from bower or somewhere else). Adding a bower wildcard path in the karma conf gets weird real fast (probably due to ordering), so we end up having to list out the deps explicitly.