lazd / iNoBounce

Stop your iOS webapp from bouncing around when scrolling
http://blog.lazd.net/iNoBounce/
BSD 2-Clause "Simplified" License
1.34k stars 400 forks source link

Breaks time scrubbing on video tag #19

Open headsuptechnologies opened 8 years ago

headsuptechnologies commented 8 years ago

Time scrubbing/seeking on the built in video controls will not get the touchmove event. Work around is to set the overflow scrolling CSS properties on the video tag's parent, but this still affects the performance of the scrubbing.

lazd commented 8 years ago

Very interesting. Maybe we can add an exception when touchstart happens inside of a video element... Can you create a fiddle that reproduces the error so I can poke at it?

On Tuesday, November 17, 2015, Jon Jensen notifications@github.com wrote:

Time scrubbing/seeking on the built in video controls will not get the touchmove event. Work around is to set the overflow scrolling CSS properties on the video tag's parent, but this still affects the performance of the scrubbing.

— Reply to this email directly or view it on GitHub https://github.com/lazd/iNoBounce/issues/19.

lazd commented 8 years ago

@headsuptechnologies perhaps we need an exception for the <video> element the same way that we have for input[type="range"] (https://github.com/lazd/iNoBounce/pull/29). Would that fix the issue?

hideyuki commented 7 years ago

I faced same problem of video and audio tag on iOS safari10. And I could fix the issue by the same way #29

if ((el.nodeName === 'INPUT' && el.getAttribute('type') === 'range') ||
    el.nodeName === 'VIDEO' || el.nodeName === 'AUDIO') {
    return;
}
lazd commented 7 years ago

@hideyuki looks good, please send a pull request for this!