Closed lgatto closed 1 year ago
Weird - can you paste the "quant" section of the config file (or the full file)? I have searched several 1000 files using release-v10 and TMT, there shouldn't be any breaking changes between these versions regarding parsing of this section of the config file.
The json file was generated from tmt.json: I loaded it into R, modified it, and serialised back to get the file below:
{
"database": {
"bucket_size": 16384,
"fragment_min_mz": 150,
"fragment_max_mz": 1500,
"peptide_min_len": 5,
"peptide_max_len": 50,
"min_ion_index": 2,
"missed_cleavages": 1,
"static_mods": {
"^": 229.1629,
"K": 229.1629,
"C": 57.0215
},
"decoy_prefix": "rev_",
"fasta": "/mnt/isilon/CBIO/data/SCPCBIO/fasta/UP000005640_9606.fasta"
},
"precursor_tol": {
"ppm": [-20, 20]
},
"fragment_tol": {
"ppm": [-10, 10]
},
"isotope_errors": [-1, 3],
"report_psms": 1,
"chimera": true,
"deisotope": true,
"output_directory": "output2",
"max_fragment_charge": 1,
"mzml_paths": ["dq_00082_11cell_90min_hrMS2_A1.mzML", "dq_00083_11cell_90min_hrMS2_A3.mzML", "dq_00084_11cell_90min_hrMS2_A5.mzML", "dq_00085_11cell_90min_hrMS2_A7.mzML", "dq_00086_11cell_90min_hrMS2_A9.mzML", "dq_00087_11cell_90min_hrMS2_A11.mzML", "dq_00088_11cell_90min_hrMS2_B1.mzML", "dq_00089_11cell_90min_hrMS2_B3.mzML", "dq_00090_11cell_90min_hrMS2_B5.mzML", "dq_00091_11cell_90min_hrMS2_B7.mzML", "dq_00092_11cell_90min_hrMS2_B9.mzML", "dq_00093_11cell_90min_hrMS2_B11.mzML"],
"quant": {
"tmt": "Tmt11",
"tmt_level": 2,
"sn": true
}
}
Running
$ ~/dev/sage/target/release/sage ../extdata/tmt2.json
produced the error, while running the following command works:
$ ~/bin/sage/sage-0.8.1/target/release/sage ../extdata/tmt2.json
Very strange. The configuration file parses fine (that's the error) for me with the latest release build downloaded from GH. It also looks completely OK to me. It looks like you are running a locally compiled version - Can you try downloading the release build?
This error doesn't really line up with the config file either: the quant
section begins on line 31.
Error: Error("unknown variant `tmt`, expected one of `Tmt6`, `Tmt10`, `Tmt11`, `Tmt16`, `Tmt18`, `User`", line: 19, column: 13)
Unrelated, it should be "tmt_sn", not "sn". For this to have any meaning, you'll need to include noise measurements in the mzML files (ThermoRawFileParser has an option for this).
I'll use the latest release build tomorrow, when back in the office and report back. Thank you for helping out.
Sounds good, let's also try a minimal example of the config file:
{
"database": {
"fasta": "/mnt/isilon/CBIO/data/SCPCBIO/fasta/UP000005640_9606.fasta"
},
"precursor_tol": {
"ppm": [-20, 20]
},
"fragment_tol": {
"ppm": [-10, 10]
},
"mzml_paths": ["dq_00082_11cell_90min_hrMS2_A1.mzML", "dq_00083_11cell_90min_hrMS2_A3.mzML", "dq_00084_11cell_90min_hrMS2_A5.mzML", "dq_00085_11cell_90min_hrMS2_A7.mzML", "dq_00086_11cell_90min_hrMS2_A9.mzML", "dq_00087_11cell_90min_hrMS2_A11.mzML", "dq_00088_11cell_90min_hrMS2_B1.mzML", "dq_00089_11cell_90min_hrMS2_B3.mzML", "dq_00090_11cell_90min_hrMS2_B5.mzML", "dq_00091_11cell_90min_hrMS2_B7.mzML", "dq_00092_11cell_90min_hrMS2_B9.mzML", "dq_00093_11cell_90min_hrMS2_B11.mzML"],
"quant": {
"tmt": "Tmt11"
}
}
Indeed, using the latest release and running
~/bin/sage/sage-v0.10.0-x86_64-unknown-linux-gnu/sage ../extdata/tmt2.json
works as expected. Will keep this in mind and always use releases in the future.
Thanks!
Still somewhat concerning - there shouldn't be any changes in the master branch since v0.10 that would affect this! But good to hear that the release build works.
If it helps, I did the following cargo build --release
, as indicated in the README.
A simple explanation could be that I simply forgot to pull the latest commit before building (although I think I did) and ended up with an old version. This might be the case, because I ended up with .pin
files when removing the quant config part, and discovered in the CHANGELOG that that's how files were named prior to version 0.6.0. But I do doubt this, as I have build/run it in the past and have never seen the .pin
files before.
OK, gotcha - I won't worry about it then :)
Running the latest version from Github (version 0.10.0 based on the ChangeLog), I get the following error when performing TMT quantitation:
The exact same config file using sage-0.8.1 works. Here's the output: