lazear / sage

Proteomics search & quantification so fast that it feels like magic
https://sage-docs.vercel.app
MIT License
201 stars 38 forks source link

Picked approaches for FDR are currently bugged #62

Closed lazear closed 1 year ago

lazear commented 1 year ago

While messing around with FDR for LFQ/peak integration, I discovered that there is currently a bug in the implementation of picked-peptide. We need to recalculate FDR/q-values based on the maximum score of the picked-pair, not the hit score. Should also re-visit how much benefit there is to picked-approaches

Note that this only affects peptide FDR, not spectrum or protein.

image
lazear commented 1 year ago

And fixed! PEP_fix_peptide PEP_fix_entrap