lazear / sage

Proteomics search & quantification so fast that it feels like magic
https://sage-docs.vercel.app
MIT License
201 stars 38 forks source link

Restrict enzyme in multiple AA #90

Closed ypriverol closed 8 months ago

ypriverol commented 9 months ago

@lazear How can you define in the restrict field when you need to define multiple AA. This is about the discussion in quantms https://github.com/bigbio/quantms/issues/296. Thanks in advance.

ypriverol commented 9 months ago

@lazear can you give us an example of a Trypsin configuration file and a Trypsin/P.

jpfeuffer commented 9 months ago

And could you clarify how one would specify no restrictions? In the linked issue we tried restrict: "" and this seems to not have been accepted at all.

Thanks! 🙏

lazear commented 9 months ago

I'm on vacation for the next 10 days or so -

Here is an example of Trypsin: https://sage-docs.vercel.app/docs/configuration/example_PXD001468

Trypsin/P would set restrict to null. The type of the restrict is Option<char>, so you cannot pass multiple characters or the empty string. The default value is null (no restrict).

lazear commented 8 months ago

Is there a case where multiple amino acids are necessary for restriction? If no such enzymes exist, I think we can probably leave as-is, right?