search

lazerous42 / Ascension-of-the-Technomancer

A "kitchen sink" type Minecraft (1.7.10) modpack centered around Advent of Ascension and GregTech intended for expert players who find the usual assortment of modpacks to be completely devoid of challenge
5 stars 4 forks source link

Looking up Arcane Crafting items results in Thaumic NEI's page for the item displaying in all R lookups afterwards #10

Open Barhandar opened 7 years ago

Barhandar commented 7 years ago

Replication: have any arcane crafting recipe known (such as Warded Jars), 'R' on a warded jar in NEI pane, close the screen, 'R' on anything else, click through tabs if warded jar recipe isn't on the very first page.

Glitches for other things crafted on arcane worktable as well, like dynamism tablets and wand caps. The page is displayed for any 'R' query, even on items which don't have any NEI-visible recipes.

lazerous42 commented 7 years ago

I'll take a look. There are currently 2 Thaumcraft NEI plugins in use, specifically to deal with the presence of custom recipes not displaying in ThaumicNEI because they haven't been discovered. Maybe it will workout ok it just use the one that doesn't have the discovery requirement.

I'll carve out time to play around with this in the next day or two. I have been extremely busy trying to get the version 5.x update ready to go. Advanced Rocketry is not the nicest mod to configure. Should the 5.x update not be ready to go in the next day or two, I'll switch gears to do some maintenance on 4.x stuff.

Barhandar commented 7 years ago

specifically to deal with the presence of custom recipes not displaying in ThaumicNEI because they haven't been discovered.

In Thaumcraft NEI Plugin. ThaumicNEI is the one you added to amend that, and also the subject of this issue.
Also, going by the code, they both have discovery requirement.

lazerous42 commented 7 years ago

So, trying to address the Thaumcraft stuff first off. Here are my evenings findings. ThaumicNEI is causing the NEI memory glitch, pretty annoying because that is the plugin that is not experiencing the custom crucible recipe problem. However, I jut loaded up a fresh instance of IE:E and grabbed an unlocked Thaumonomicon. Low and behold, the null catalyst (my test case as it's a custom recipe that came from IE:E) does appear in ThamucraftNEIPlugin. This indicates one of two things

1) Something scripty I did in some line/file is having a negative interaction with the existing recipe for the null catalyst, a recipe that remains unchanged from IE:E in AotT. Less likely, but certainly possible 2) Another mod, probably an NEI plugin is causing the custom crucible recipes not to behave correctly.

I don't have an answer yet, but at least I know the parameters of the NEI memory buffering glitch, the fact that IE:E i working correctly, and that it only seems to effect crucible recipes. It's getting late, but I will pick up from here tomorrow.

Barhandar commented 7 years ago

Another mod or Thaumcraft scripts. Does IE:E modify Thaumcraft research?
Two research avenues: 1. Move Thaumcraft-affecting scripts from AotT to IE:E, check NEI; 2. Add Thaumcraft addons from AotT to IE:E, check NEI.

Also, it's not custom crucible recipes that are invisible, with TNEIP can't see any crucible recipes on 'R', but can see them all on 'U', including null catalyst and thaumium.
https://github.com/DjGiannuzz/Thaumcraft-NEI-Plugin/issues/26

lazerous42 commented 7 years ago

This was also posted in the Thaumcraft NEI Plugin project (more information below that though)

I just spent the last 8 hours reviewing this issue trying to get it down to the simplest case possible and I cannot figure out why my pack (where the issue was initially reported) was having this problem. I made a test instance using just the API mods from my pack + BoP (for config file compatibility). This is one of my testing techniques. I copy a test pack I have with just Ascension of the Technomancer required libraries and as little content as possible, then start from there to try and make the simplest scenario to reproduce as possible. Whittling this core down to just a tiny fraction of mods that are common with IE:E (no more DragonAPI, no NotEnoughIDs), the problem remained. I then reset the configs back to their defaults and used Beyond Compare to sync them with IE:E and the problem remained. I'm at a total loss of what else to try as I stripped out virtually everything in the pack and was still experiencing the problem using just the most essential libraries, NEI + Addons, WAILA, and Thaumcraft. I checked the Forge versions in use and the Java args and to no avail. That doesn't mean that there isn't still some bad record registered somewhere that I missed, but it's pretty unlikely. Hopefully we can find some enlightenment about this out in the community, as I would certainly rather not have 2 TC NEI plugins, it's just sloppy. I just can't spend forever on just this one thing, this is a one man show so I need to speared out my time wisely. I'm still trying for AOBD and AnyIron/AnyCopper issue cleanup.

So I did find a mention of similar things mentioned to JadedCat for Agrarian Skies 2. She mentioned back dating gui_thaumicnei from 1.3 - 1.23. This prevents the problem of TC recipes getting stuck in the buffer. I'll close this issue out when I post the updated pack to FTB tomorrow. I'm going to make on more pass to see if there is anything else I can pack in to 4.x for fixes, then I have to get back to the 5.x update process, as this is also a part of a bug fix and it's a Chromaticraft progression breaker so it's a high priority.

Also, I want to use some of my time off from work this week for actually playing and recording, which is also a core testing technique. I've caught most of the nastier bugs on my own without ever bothering anyone with them.