lazerous42 / Ascension-of-the-Technomancer

A "kitchen sink" type Minecraft (1.7.10) modpack centered around Advent of Ascension and GregTech intended for expert players who find the usual assortment of modpacks to be completely devoid of challenge
5 stars 4 forks source link

Wrought iron is pickup-unified to regular iron due to `ingotAnyIron` oredict #9

Closed Barhandar closed 7 years ago

Barhandar commented 7 years ago

Might also happen for anything else registered as ingotAnyX (GT treats it as a "AnyX" independent material, from which the ingot item is made). Doesn't happen for copper and annealed copper, I guess because the ingotAnyCopper is second entry on them, not first like with iron.
Bronze also has ingotAnyBronze, which is also second entry, and additionally mirrors ingotBronze - black and bismuth bronzes lack it (they're also significantly more difficult to make, requiring EBF, and for black, vacuum freezer, so it's justified).

Replication: cheat in GT wrought iron ingot, throw it on the ground, pick up. GardenStuff Wrought Iron will get unified into GT wrought iron unless it results in over a full stack of GT wrought iron - all excess is transformed into regular iron ingots.

EDIT: additionally, it causes issues with anything else which creates its items procedurally. As such, there are things like AnyIron Clusters (AOBD) and Purified AnyIron (Technomancy). Also applies to AnyCopper and the aluminium (because of course Sanguimancy and Technomancy can't tell that Aluminum, Aluminium and NaturalAluminum are the same thing).

lazerous42 commented 7 years ago

Should be pretty easy to correct. Same thing as the other issue. If I don't get through the 5.x update stuff in the next day or two. I will switch gears to make a final hotfix version release for 4.x

Barhandar commented 7 years ago

This issue is caused by erroneous behavior of Just What I Needed mod (it ignores option to disable ingot unification). It unifies ores to the lowest-ID one as well, instead of to specific mod or controllable in a non-binary way. I suggest disabling conversion options in JWIN entirely (S:OrePickupEnabled=false).

You might still want to remove AnyIron and AnyCopper entries where applicable due to JABBA's non-disableable unification exploit (same reason InfiTech 2 did), or contend with players being able to freely convert regular iron and copper into wrought and annealed, respectively, once they have some.

EDIT: Also, for prevention of annoyance, disable AnyIron and AnyCopper in configs for AOBD and Technomancy. Can't disable them for Sanguimancy, sadly.

lazerous42 commented 7 years ago

Sweet, that's a time saver. As this is totally straightforward, I will pop this in as soon as the Thaumcraft research starts driving me batty ;-)

lazerous42 commented 7 years ago

In version 4.2.2 have deactivated (S:OrePickupEnabled=false) in JWIN to prevent it from trying to override GT unification. Changes to AOBD are going to be handled with the AOBD configuration changes needed for #13., along with changes to anyIron and anyCopper.

You can grab the configs from here as mentioned in the WATERCREATURE spawn span from #15

lazerous42 commented 7 years ago

I have added the oredict cleanup from InfiTech 2 to prevent using JABBA barrels or Storage drawers to pull any shenanigans with annealed copper or wrought iron. AnyIron/AnyCopper are also deactivated in AOBD and Technomancy. This is in version 4.3.9, I'm going to cut the version here and post all these changes to FTB and resume work on the 5.x update now so I can try and get that ready in the next few days.