search

lazurey / strapi-plugin-content-export-import

Strapi plugin for content export and import
166 stars 47 forks source link

Updating to the last strapi version. #13

Closed SalahAdDin closed 4 years ago

SalahAdDin commented 4 years ago

It solves the bug by we can't see the plugin in the left panel: https://github.com/lazurey/strapi-plugin-content-export-import/issues/12

lazurey commented 4 years ago

Hello @SalahAdDin thanks a lot for your effort! To merge this PR, could you have a look at the test? or you can run npm run test to have a check at local. If 90% coverage is too high, you can adjust it to 80% in jest.config.js

SalahAdDin commented 4 years ago

@lazurey Hi, I will review, but honestly, I don't know what is the problem with the test, I didn't change anything about CSS, that's why I don't understand what is the problem there.

ozamorowski commented 4 years ago

@SalahAdDin, you removed lifecycles from plugin definition, so test are failing. Also there is no need to upgrade strapi-helper-plugin, this is probably change for another PR.

SalahAdDin commented 4 years ago

@ozamorowski But it creates warnings inside of the admin(check it with watch mode).

SalahAdDin commented 4 years ago

@ozamorowski your solution is better, go ahead with it @lazurey. please.