search

lazyMods / baubles

1.14.4/1.15.2 Version of @Azanor BaublesAPI Mod
9 stars 5 forks source link

[1.18.1] Fix unobfuscated method name in findMethod call #22

Closed SuperMartijn642 closed 2 years ago

SuperMartijn642 commented 2 years ago

Current problem

ObfuscationReflectionHelper#findMethod requires an obfuscated method name. Currently, it uses the mojmaps name leading to a crash ingame. This likely came about when automatically updating method names from a previous Minecraft version.

Fix in this PR

This PR changes the method name, slotChangedCraftingGrid, to its obfuscated equivalent m_150546_. Thus, it can now find the method and doesn't crash.

Crash logs

These came from a report for Packed Up https://github.com/SuperMartijn642/PackedUp/issues/33.

lazynessmind commented 2 years ago

Thanks for fixing it, I didn't notice that while testing it.

lazynessmind commented 2 years ago

Once again, thanks for fixing it. Curse finally approved it https://www.curseforge.com/minecraft/mc-mods/baubles-reborn/files/3576950

SuperMartijn642 commented 2 years ago

Thanks for merging it so quickly 🙂

I didn't notice that while testing it

Ah yes, it only breaks outside the dev environment, so that's probably why you hadn't noticed.