lazyjinchuriki / cinephile

Movies and Shows finder site with HTML, CSS, Vanilla JS
https://lazyjinchuriki.github.io/cinephile/
22 stars 37 forks source link

update header #16

Closed MAVERICK-VF142 closed 1 year ago

MAVERICK-VF142 commented 1 year ago
  1. addition of logo and name in header
GD0910 commented 1 year ago

can i work on this issue @lazyjinchuriki

lazyjinchuriki commented 1 year ago

It should be mobile responsive.

GD0910 commented 1 year ago

Do you have a logo ?

lazyjinchuriki commented 1 year ago

You can add this one : https://avatars.githubusercontent.com/u/92175633?v=4

MAVERICK-VF142 commented 1 year ago

@lazyjinchuriki thanks. Please assign it to me

GD0910 commented 1 year ago

You can add this one : https://avatars.githubusercontent.com/u/92175633?v=4

Ok I can try

GD0910 commented 1 year ago

@lazyjinchuriki thanks. Please assign it to me

i am new to open source and it will be great for me to work with you in this project

lazyjinchuriki commented 1 year ago

You need to first fork this repo, Then clone it to your pc/laptop After cloning you have to add that image to the header. The you have to push those changes first to your forked repo, come back to that repo you'll see an option to create a pull request. That's it.

GD0910 commented 1 year ago

ok will try it can you put this issue under hacktoberfest tag Thankyou .Will start working on this issue

GD0910 commented 1 year ago

@lazyjinchuriki Any changes or should i raise PR image

lazyjinchuriki commented 1 year ago

Decrease the size of logo to fit perfectly with the tv shows switch button.

MAVERICK-VF142 commented 1 year ago

@lazyjinchuriki @GD0910 This kind of seems unethical me raising the issue and you are not assigning the issue to me and someone random barges into someone else's issue and starts working on it not good open source practice

lazyjinchuriki commented 1 year ago

You should've told me that you are planning on working on it and not just pointing an Issue. Everybody else asks to assign them the issue and I have assigned each and every one. Now it's not my fault that someone else came and grabbed your issue.

GD0910 commented 1 year ago

@lazyjinchuriki can u assign me so that my contibution can be seen and please add hacktoberfest tag for this issue Will raise the PR in some time