search

lazyjinchuriki / pokedex

A Pokedex website made in HTML5, CSS, Vanilla Javascript
https://lazyjinchuriki.github.io/pokedex/
22 stars 21 forks source link

Fix: flicker when hovering on cards #26

Closed Shubhamm33 closed 10 months ago

Shubhamm33 commented 10 months ago

issue: There is a flickering issue when hovering on the card https://github.com/lazyjinchuriki/pokedex/assets/38568811/3805857a-e952-4962-9c9e-791f58b656bf

lazyjinchuriki commented 10 months ago

I can assign this issue to you under Hactoberfest. Can you work on that?

Shubhamm33 commented 10 months ago

Yes i've forked it, theres also some js issue in console.. i'll fix that too

AniketP04 commented 10 months ago

I'm willing to work on this issue and collaborate with the maintainers. Please let me know how I can proceed.

Kelvin-K commented 10 months ago

I saw the issue was still pending so I went ahead and created a pull request. If you find this suitable, please assign this issue to me.

Shubhamm33 commented 10 months ago

Okay awesome... i have pulled the updated there are minor errors displaying in console.. fixed them as well... please merge the updated, sending a PR t19

lazyjinchuriki commented 10 months ago

Thanks.

Shubhamm33 commented 10 months ago

There are 2 errors which i'm getting, one for the images, which i'm ignoring since its loading on your end...

Other one is the /v2/type error... for some pokemon /v2/type is not present in their response structure... there are only 20 pokemon links available on the types endpoint

t20 t21 After 18 it has nothing, which gives error

i have also checked their documentation, it returns undefined for pokemon after 18, since its not present in the response body itself t22 t23

Do you know why is that ? I'm not able to understand, they dont have any issue in their docs as well..

lazyjinchuriki commented 10 months ago

You see the type endpoint does not refer to each pokemon, instead it refers to each types (i.e. fire, water etc.) There are only 20-21 types i think thus it will return undefined for more than that. This issue is because someone created a PR for showing Strong Against and Weak Against types and I unknowingly merged it.

Shubhamm33 commented 10 months ago

ohh okay got it now... so first we need to fetch the pokemon type from pokemon, then their respective type data using this type endpoint... i'll try this out then let you know

lazyjinchuriki commented 10 months ago

You're the best!!

Shubhamm33 commented 10 months ago

Thankyou so much i'll probably work on this in evening, currently in office!