search

lazypower / DNS-Charm

DNS Charm
MIT License
7 stars 5 forks source link

Support removing multiple relations when programmable-multiple is broken #16

Closed lazypower closed 8 years ago

lazypower commented 9 years ago

This can be kind of militant, and in order to make it idempotent I left it be at catching key errors, and allowing the execution to continue processing. This may yield instances where a record is removed accidentally and probably warrants further investigation.

lazypower commented 9 years ago

@mirw can you take a look at this branch and see if it resolves #8 for your use cases? this works as expected w/ the test data in the dtest charm. However I feel like its a bit militant and might wind up wiping things we aren't expecting, and should probably the validated with an IP Address of the host.

LMK what your findings are and what you think it needs if anything.

mirw commented 9 years ago

@chuckbutler, sorry for the delay on this - it's on my to-do list but I'm a bit swamped at the moment. I hope to be able to look at this (and your other pull request) next week - is that OK?

lazypower commented 9 years ago

Sounds good @mirw, thanks for taking a look!

I also have some prelim Rt53 work incoming, but I don't know how useful it will be for your uses, as it doesn't appear to support NAPTR resources.

mirw commented 9 years ago

@rkd-msw, please can you take a look?

rkday-pro commented 9 years ago

@chuckbutler , I've tried to test, but the charm seems to be trying to use easy_install without installing it first:

2015-06-26 17:02:56 DEBUG juju.worker.leadership tracker.go:123 dns/0 making initial claim for dns leadership
2015-06-26 17:02:56 DEBUG juju.worker.leadership tracker.go:165 checking dns/0 for dns leadership
2015-06-26 17:02:56 DEBUG juju.worker.proxyupdater proxyupdater.go:151 new proxy settings proxy.Settings{Http:"", Https:"", Ftp:"", NoProxy:""}
2015-06-26 17:02:56 DEBUG juju.worker.logger logger.go:45 reconfiguring logging from "<root>=DEBUG" to "<root>=WARNING;unit=DEBUG"
2015-06-26 17:02:58 INFO install /var/lib/juju/agents/unit-dns-0/charm/hooks/install: line 5: easy_install: command not found
2015-06-26 17:02:58 ERROR juju.worker.uniter.operation runhook.go:107 hook "install" failed: exit status 127
rkday-pro commented 9 years ago

(This is the base Ubuntu 12.04 cloud image, imported into OpenStack.)

lazypower commented 9 years ago

Well thats fun. Its present on our 14.04 CPC images across a multitude of providers. I'll grab an extra patch set to plug in python-software-properties which should resolve this. Thanks for giving it a look @rkd-msw. I'll follow up when that's been patched