search

lazypower / DNS-Charm

DNS Charm
MIT License
7 stars 5 forks source link

Update to work with Clearwater again #26

Closed thomnico closed 9 years ago

thomnico commented 9 years ago

Juju provide the IP instead of name in unit-get private-adress Enable SRV and NAPR methods for bind Re enable pointing to cloud dns as forwarder if bind is used.

lazypower commented 9 years ago

Overall this merge looks great, there is however some missing tests for validating the forwarding bits.

DOnt worry about the drone failing check above, I have some tests that need refactored as well, but before I accept this patch to the DNS Forwarding bits, i'd like to see some tests validating it works, and move that bit of logic into its own method being called from the install method.

Great start @thomnico, and thanks for the contribution! :+1: