search

lazypower / DNS-Charm

DNS Charm
MIT License
7 stars 5 forks source link

Update A records with changes, rather than overwriting them #28

Closed rkday-pro closed 6 years ago

rkday-pro commented 8 years ago

This fixes #3 - I've tested it live.

This change doesn't make it possible for clients to choose whether they should overwrite or update a record - partly because I wasn't sure what a sensible API would be, and partly to be consistent with AAAA records (where changes always trigger an update).

Do you think offering this choice is necessary (or will it just be irrelevant once https://github.com/chuckbutler/DNS-Charm/issues/8 is fixed, and deleted nodes remove themselves)? If you do, what do you think the API should be?

lazypower commented 8 years ago

@rkd-msw ah, I didn't notice this PR until just now. thanks for the contribution. I need to look deeper into why the CI tests are failing, it looks like the format has changed from what its expecting.

I'll set aside some time this evening to pull and review. Again, sorry about the delay