search

lazytiger / gumbo-query

c++ library to provide jQuery style api for gumbo library
MIT License
263 stars 81 forks source link

Ubuntu 14.04 x64 LTS compile gumbo-query error. #22

Open nifflin opened 8 years ago

nifflin commented 8 years ago

-- The CXX compiler identification is GNU 4.8.4 -- Check for working CXX compiler: /usr/bin/c++ -- Check for working CXX compiler: /usr/bin/c++ -- works -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Detecting CXX compile features -- Detecting CXX compile features - done CMake Error at cmake/LibFindMacros.cmake:259 (message): REQUIRED PACKAGE NOT FOUND

We only found some files of Gumbo, not all of them. Perhaps your installation is incomplete or maybe we just didn't look in the right place? This package is REQUIRED and you need to install it or adjust CMake configuration in order to continue building gumbo_query.

Relevant CMake configuration variables:

Gumbo_INCLUDE_DIR=/usr/local/include
Gumbo_LIBRARY=<not found>
Gumbo_static_LIBRARY=/usr/local/lib/libgumbo.a

You may use CMake GUI, cmake -D or ccmake to modify the values. Delete CMakeCache.txt to discard all values and force full re-detection if necessary.

Call Stack (most recent call first): cmake/FindGumbo.cmake:39 (libfind_process) CMakeLists.txt:20 (find_package)

-- Configuring incomplete, errors occurred!

nifflin commented 8 years ago

I found something wierd. git clone https://github.com/Falven/gumbo-query download a old version source code which /cmake/FindGumbo.cmake doesnot have "libgumbo.so" but git@github.com:lazytiger/gumbo-query.git download a latest version source code which /cmake/FindGumbo.cmake have "libgumbo.so".

This difference caused compile error.

Is this a bug of github?

emrahayanoglu commented 6 years ago

I also experienced the same problem and realized that libgumbo.so is not introduced in the FindGumbo.cmake file. It should be introduced since in the linux side, the libraries are stored with so extension.

I'll propose a PR for related fix