Project Feedback

[lazzaror]

Build a website that allows the user to switch between day and night color themes and remembers their choice

@egillespie Can you take a look at this? It's hosted here and meets the following criteria:

• [x] Includes a button that when clicked, will toggle the website between day and night themes
• [x] When a user changes the theme, their choice is remembered in localStorage
• [x] The class on the body element is always up-to-date with the current theme (either day-theme or night-theme) -- you can use document.body.setAttribute('class', 'some-class-name') to set the class on the body
• [x] When the body has the class day-theme, the background of the website is light-colored, with a darker color for the text
• [x] When the body has the class night-theme, the background of the website is a very dark color, with a lighter color for the text
• [x] Somewhere on the page, the user is told how many times they've visited the website (starting with 1 the first time)

[egillespie]

Sweeeet, I really like the different background based on the theme and that it's totally based on a CSS class! The local storage part is working great too. Nice job! 🤘

I have one recommendation to touch up the page counter. Would you mind trying this out?

Show 1 on first visit to page

When I first visited the page, I saw NaN as the page count:

On subsequent visits I saw the number start at 1 and increase each time I refreshed the page, so I'm convinced that the local storage bit is working correctly.

Would you mind adjusting the code so it shows 1 on the first page visit instead of NaN? You can run window.localStorage.clear() to remove all of the saved values in local storage to reproduce this issue.

---

After you’ve made your changes and pushed them to GitHub and your hosted site, give it a once-over to make sure it looks right, then comment back here and I’ll take another look.

Thanks! 🎸

[lazzaror]

Thanks! Just fixed it

[egillespie]

Nailed it. Nice work! 🔨 :shipit: