refactor: refactor implementation and design smells

[jeffrypaul37]

The following classes were refactored to fix certain code smells and design issues:

• MeasuredShape.java
• ColorPickerSliderUI.java
• ShapeBounds.java
• FastNoiseLite.java
• TransformLayer.java
• TextLayer.java

All tests pass and the build is successful.

[lbalazscs]

Hi Jeffry,

Thank you for your contribution to Pixelitor! Unfortunately, I'm unable to merge (or even review) this pull request. There are several reasons for this:

• It includes too many changes, with 142 changed files, according to the "Files changed" tab.
• The request isn't based on the latest version.
• It contains purely stylistic changes.
• It modifies library code (code outside the "pixelitor" package).

Please note that in the latest commit, I have updated the https://github.com/lbalazscs/Pixelitor/blob/master/CONTRIBUTING.md file to provide clearer guidelines. I encourage you to review the new version. If you still wish to contribute, please discuss your ideas first, for example by adding comments to this pull request.

[jeffrypaul37]

Thank you for reaching out! Moving forward, I'll keep these in mind before raising pull requests.

Thank you once again for your quick response and valuable feedback.

Regards, Jeffry Paul

---

From: László Balázs-Csíki @.> Sent: Friday, March 29, 2024 9:19 AM To: lbalazscs/Pixelitor @.> Cc: Jeffry Paul @.>; Author @.> Subject: Re: [lbalazscs/Pixelitor] refactor: refactor implementation and design smells (PR #353)

Hi Jeffry,

Thank you for your contribution to Pixelitor! Unfortunately, I'm unable to merge (or even review) this pull request. There are several reasons for this:

• It includes too many changes, with 142 changed files, according to the "Files changed" tab.
• The request isn't based on the latest version.
• It contains purely stylistic changes.
• It modifies library code (code outside the "pixelitor" package).

Please note that in the latest commit, I have updated the https://github.com/lbalazscs/Pixelitor/blob/master/CONTRIBUTING.md file to provide clearer guidelines. I encourage you to review the new version. If you still wish to contribute, please discuss your ideas first, for example by adding comments to this pull request.

— Reply to this email directly, view it on GitHubhttps://github.com/lbalazscs/Pixelitor/pull/353#issuecomment-2027172867, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOTSZCDKY54H335GOLVUNQ3Y2VE33AVCNFSM6AAAAABFOE5Q52VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRXGE3TEOBWG4. You are receiving this because you authored the thread.Message ID: @.***>