lballabio / QuantLib

The QuantLib C++ library
http://quantlib.org
Other
5.43k stars 1.8k forks source link

Change the order of `QL_DEPRECATED_...` macro definition #2078

Closed ralfkonrad closed 2 months ago

ralfkonrad commented 2 months ago

The definition should be turned around as clang defines __GNUC__ itself (in my case for clang++18 to __GNUC__ == 4, probably to be underneath a valid gcc version).

More an esthetic PR as clang is able to handle the _Pragma("GCC ...") too.

coveralls commented 2 months ago

Coverage Status

coverage: 72.674%. remained the same when pulling 5b0053be3cbbdde510223236d4136779ffe6013f on ralfkonrad:bugfix/clang_deprection_error into fb835109c8103776db52c4d4552fa69181de458e on lballabio:master.