search

lballabio / QuantLib

The QuantLib C++ library
http://quantlib.org
Other
5.33k stars 1.79k forks source link

New Zealand Calendar - minor issues #2100

Open lukedavis8767 opened 1 week ago

lukedavis8767 commented 1 week ago

newzealand.cpp:

  1. Missing Queen Elizabeth's funeral (26th september 2022): https://en.wikipedia.org/wiki/Queen_Elizabeth_II_Memorial_Day
  2. It looks like Anniversary day is following the date for Wellington. Considering that Auckland is the financial centre for NZ, does it make sense to instead use the Auckland date, which falls on the Monday nearest to the 29th of January?
boring-cyborg[bot] commented 1 week ago

Thanks for posting! It might take a while before we look at your issue, so don't worry if there seems to be no feedback. We'll get to it.

lballabio commented 1 week ago

Ok, thanks. We should probably have different sub-calendars for Wellington and Auckland so we can let people choose. Are there any other differences between the two? Some regional Auckland holidays, perhaps? Thanks!

lukedavis8767 commented 1 week ago

https://www.govt.nz/browse/work/public-holidays-and-work/public-holidays-and-anniversary-dates/

From what we can see every other date is identical. It's just the anniversary day is different