Closed johndharrison closed 7 years ago
Hey, thanks for the good word and the report! I'd love to get it to compile in MacOS. My only problem is that I don't have access to this system. However, since only pipe2 is missing according to your report I'll try to look it up and maybe have you run the compilation again?
@lbartnik I have a mac in the cloud for testing purposes. Let me know if you want me to run any changes you make on it.
Hey @johndharrison, so it seems that only the pipe2() call needs to be fixed. Could you please give this branch a try? https://github.com/lbartnik/subprocess/tree/fix-compilation
@lbartnik I ran the fix-compilation branch on a OSX el capitain build. I also ran it on TRAVIS on:
osx_image: xcode8 Xcode 8gm OS X 10.11
The relevant yml is here :
https://github.com/johndharrison/subprocess/blob/fix-compilation/.travis.yml
Both runs failed to install the install log can be seen at
https://travis-ci.org/johndharrison/subprocess/jobs/180647454#L939
Hey, I pushed a change that should fix it - I was actually able to find a mac VM. However, tests are Linux-specific and still fail - I think the package can be used, though.
Yeah that compiles and installs. I went through some of the vignette examples and they all run fine. I will try it on a real world example tomorrow and let you know if I see any issues.
There's a problem on Mac that I haven't encountered in Linux nor Windows. It seems that sometimes multi-byte characters are broken into parts when I do read() on a pipe. R fails saying that the "multibyte character" is "invalid". I'm not sure yet what to do with that.
I believe this has been addressed in #22
Hi Lukasz,
Great job getting this on CRAN it definitely addresses an area that base R is perhaps lacking in. Is there any plans to have subprocess run on OSX. At the moment it fails to install as follows: