Closed nsfinkelstein closed 7 years ago
Yes, sure. Give me a few hours.
On Thu, Dec 15, 2016, 17:49 Noam Finkelstein notifications@github.com wrote:
@lbartnik https://github.com/lbartnik
As discussed in n-s-f/mockery#15 https://github.com/n-s-f/mockery/issues/15, I've renamed expect_no_calls to expect_called.
However I cannot push this change to CRAN because subprocess depends on mockery, and this change breaks subprocess's test. Can you fix the dependency to version 0.2.0, so I can make breaking changes? I'd rather not have to keep expect_no_calls around for backwards compatibility at this stage - though if you would prefer, I could just keep it as an alias to expect_called.
Thanks
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/lbartnik/subprocess/issues/30, or mute the thread https://github.com/notifications/unsubscribe-auth/AFBH4NaPPA37RRqQEtujAVRNjisMt_5Vks5rIe5GgaJpZM4LOxLZ .
Thanks! No rush at all.
Hey @n-s-f,
I'm afraid I can make the change in GitHub but I'm not ready to push a new version to CRAN yet. So you might need to leave a backwards-compatible API after all.
Lukasz
No problem, will do.
Thanks Noam
@lbartnik Actually it seems to have made it onto CRAN in the iterm without the alias.
@lbartnik
As discussed in https://github.com/n-s-f/mockery/issues/15, I've renamed
expect_no_calls
toexpect_called
.However I cannot push this change to CRAN because subprocess depends on mockery, and this change breaks subprocess's test. Can you fix the dependency to version 0.2.0, so I can make breaking changes? I'd rather not have to keep
expect_no_calls
around for backwards compatibility at this stage - though if you would prefer, I could just keep it as an alias toexpect_called
.Thanks