search

lbartnik / subprocess

Other
49 stars 10 forks source link

Add process_exists() #62

Closed lbartnik closed 6 years ago

lbartnik commented 6 years ago

OS-level process_exists() is required in the devel R build in Windows, where the system2() call seems to randomly lose the output from tasklist (the previous implementation method of process_exists()) and seems to be a bug in R 3.6. However, it also removes a source of headaches when checking external processes with command-line tools like ps or tasklist.

codecov-io commented 6 years ago

Codecov Report

Merging #62 into master will decrease coverage by 1.6%. The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
- Coverage   76.64%   75.03%   -1.61%     
==========================================
  Files          12       12              
  Lines         638      649      +11     
==========================================
- Hits          489      487       -2     
- Misses        149      162      +13
Impacted Files Coverage Δ
src/registration.cpp 0% <ø> (ø) :arrow_up:
src/subprocess.h 62.5% <ø> (ø) :arrow_up:
R/subprocess.R 100% <100%> (ø) :arrow_up:
src/sub-linux.cc 59.49% <100%> (-4.77%) :arrow_down:
src/rapi.cc 82.37% <88.88%> (+0.02%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2b5d32a...7297e2b. Read the comment docs.