Racon does not build against latest edlib

[tillea]

Hi, I upgraded the Debian package of edlib to the latest version 1.2.7. Unfortunately racon does not build against this as it is reported in a bug report:

/usr/bin/ld: CMakeFiles/racon_test.dir/test/racon_test.cpp.o: in function `calculateEditDistance(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >     const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)':
./obj-x86_64-linux-gnu/./test/racon_test.cpp:18: undefined reference to `edlibDefaultAlignConfig'
/usr/bin/ld: ./obj-x86_64-linux-gnu/./test/racon_test.cpp:18: undefined reference to `edlibAlign'
/usr/bin/ld: ./obj-x86_64-linux-gnu/./test/racon_test.cpp:22: undefined reference to `edlibFreeAlignResult'
/usr/bin/ld: CMakeFiles/racon_test.dir/src/overlap.cpp.o: in function `racon::Overlap::align_overlaps(char const*, unsigned int, char const*, unsigned int)':
./obj-x86_64-linux-gnu/./src/overlap.cpp:208: undefined reference to `edlibNewAlignConfig'
/usr/bin/ld: ./obj-x86_64-linux-gnu/./src/overlap.cpp:208: undefined reference to `edlibAlign'
/usr/bin/ld: ./obj-x86_64-linux-gnu/./src/overlap.cpp:213: undefined reference to `edlibAlignmentToCigar'
/usr/bin/ld: ./obj-x86_64-linux-gnu/./src/overlap.cpp:223: undefined reference to `edlibFreeAlignResult'
collect2: error: ld returned 1 exit status

I wonder whether you plan to adapt racon to the latest edlib (and in case it is just done in some not yet tagged commit whether you intend to tag this as release). Kind regards, Andreas.

[rvaser]

Hi Andreas, it is a bit tricky, I'll try and update the whole build in a week.

Best regards, Robert

[tillea]

Hi Robert, any success in fixing this? If yes, a new release tag would be helpful. Kind regards, Andreas.

[rvaser]

I am sorry Andreas, things have been hectic recently. I will update it as soon as possible.

Best regards, Robert

[tillea]

Am Wed, Nov 24, 2021 at 07:02:38PM -0800 schrieb Robert Vaser:

I am sorry Andreas, things have been hectic recently. I will update it as soon as possible. No problem. Seems you found a solution which looks promising. Thanks a lot for working on this, Andreas.

[rvaser]

I hope that branch build will work, I am waiting for a review before I merge and tag a new release.

[tillea]

Am Fri, Nov 26, 2021 at 12:01:07AM -0800 schrieb Robert Vaser:

I hope that branch build will work, I am waiting for a review before I merge and tag a new release. Thanks a lot for keeping me up to date, Andreas.

[nileshpatra]

Hey @rvaser thanks a lot for working on this.

I hope that branch build will work, I am waiting for a review before I merge and tag a new release.

Did you happen to get some review yet? If not, would any of it be in pipeline?

Let me know.

Regards, Nilesh

[rvaser]

Terribly sorry for this delay, I have merged and released the changes (v1.5.0).

Best regards, Robert