lbcb-sci / racon

Ultrafast consensus module for raw de novo genome assembly of long uncorrected reads
MIT License
197 stars 34 forks source link

CMake file doesn't recognize apple-m1 chips #83

Open ephillips42 opened 3 months ago

ephillips42 commented 3 months ago

When trying to build racon on a computer with an apple-m1 chip it gives the error "error: unknown target CPU 'apple-m1' note: valid target CPU values are: nocona, core2, penryn, bonnell, atom, silvermont, slm, goldmont, goldmont-plus, tremont, nehalem, corei7, westmere, sandybridge, corei7-avx, ivybridge, core-avx-i, haswell, core-avx2, broadwell, skylake, skylake-avx512, skx, cascadelake, cooperlake, cannonlake, icelake-client, rocketlake, icelake-server, tigerlake, sapphirerapids, alderlake, knl, knm, k8, athlon64, athlon-fx, opteron, k8-sse3, athlon64-sse3, opteron-sse3, amdfam10, barcelona, btver1, btver2, bdver1, bdver2, bdver3, bdver4, znver1, znver2, znver3, x86-64, x86-64-v2, x86-64-v3, x86-64-v4" Could apple silicon chips be added? Thanks!

YoshitakaMo commented 1 month ago

I've created Homebrew formula for racon 1.5.0. Please try brew install brewsci/bio/racon on Apple Silicon. However, I noticed that ./racon-test failed on some unit tests on both Intel and M1 Macs, though all tests were passed on Linux OS.

$ /path/to/racon_test # after manual installation on Intel Mac
...
...
[racon::Polisher::initialize] loaded target sequences 0.017256 s
[racon::Polisher::initialize] loaded sequences 0.017341 s
[racon::Polisher::initialize] loaded overlaps 0.003315 s
[racon::Polisher::initialize] aligning overlaps [====================] 3.256364 s
[racon::Polisher::initialize] transformed data into windows 0.033123 s
[racon::Polisher::polish] generating consensus [====================] 6.708137 s
/tmp/racon-20240810-87726-qxpzm/test/racon_test.cpp:294: Failure
Expected equality of these values:
  total_length
    Which is: 1658386
  1658216
[racon::Polisher::] total = 10.036378 s
[  FAILED  ] RaconPolishingTest.FragmentCorrectionWithQualitiesFullMhap (10043 ms)
[----------] 10 tests from RaconPolishingTest (35330 ms total)

[----------] Global test environment tear-down
[==========] 15 tests from 2 test suites ran. (35340 ms total)
[  PASSED  ] 6 tests.
[  FAILED  ] 9 tests, listed below:
[  FAILED  ] RaconPolishingTest.ConsensusWithQualities
[  FAILED  ] RaconPolishingTest.ConsensusWithoutQualities
[  FAILED  ] RaconPolishingTest.ConsensusWithQualitiesAndAlignments
[  FAILED  ] RaconPolishingTest.ConsensusWithoutQualitiesAndWithAlignments
[  FAILED  ] RaconPolishingTest.ConsensusWithQualitiesLargerWindow
[  FAILED  ] RaconPolishingTest.ConsensusWithQualitiesEditDistance
[  FAILED  ] RaconPolishingTest.FragmentCorrectionWithQualitiesFull
[  FAILED  ] RaconPolishingTest.FragmentCorrectionWithoutQualitiesFull
[  FAILED  ] RaconPolishingTest.FragmentCorrectionWithQualitiesFullMhap