search

lbellonda / qxmledit

QXmlEdit XML editor. Downloads: https://sourceforge.net/projects/qxmledit/files
http://qxmledit.org
Other
160 stars 46 forks source link

Snapcraft qxmledit #60

Closed frederickjh closed 5 years ago

frederickjh commented 5 years ago

This pull request adds the snapcraft.yaml required to build the snap of QXmlEdit on snapcraft.io.

lbellonda commented 5 years ago

Would you like to specify the license under which your file is released and put an header on it? Also do you mind to be cited between contributors by name or email? I think to put the script under "install_script" folder.

frederickjh commented 5 years ago

@lbellonda The license would be the same as QXmlEdit's license. I have my repository licensed using the MIT license, but it that does not set the license on my pull request on your project. I do see that there is a configuration item to specify the license for the QXmlEdit project. I see three license files in QXmlEdit so I am not sure what I should add. See this page about Snapcraft top-level metadata to see the license codes that can be used. Let me know which ones I should add and I will add whatever is necessary and test.

Not sure what you mean by a header or why it would be added. You can add me to the contributors list.

As to the location of the Snapcraft fille to build the Snap, build.snapcraft.io only allows snapcraft.yaml at /snap/snapcraft.yaml, /snapcraft.yaml or /.snapcraft.yaml. I used the recommended location and it builds correctly using this location. I would recommend using the current location, so that when the project decides to take over building the Snap itself the repository can be switched from frederickjh/qxmledit to this one.

frederickjh commented 5 years ago

Here is a link to the information that I could find about the location of the snapcraft.yaml file.

frederickjh commented 5 years ago

@lbellonda Thanks for accepting this pull request, and again let me know in the future if you and the other maintainers want to move the making of the snap package to this repository.

In any case until if you could send me a personal message when you make a new release, so I know that I need to rebuild the snap with the new version, I would appreciate it.