search

lbellonda / qxmledit

QXmlEdit XML editor. Downloads: https://sourceforge.net/projects/qxmledit/files
http://qxmledit.org
Other
160 stars 46 forks source link

Invalid appdata metainfo file #63

Closed Vogtinator closed 4 years ago

Vogtinator commented 5 years ago

The appdata metainfo xml file is invalid:

https://github.com/lbellonda/qxmledit/blob/27f7bb6154035e8dc3e63f2c2fb4fcbb94aeafa3/install_scripts/environment/desktop/QXmlEdit.appdata.xml#L5

This was causing crashes in AppStream and narrowed down to this component extending itself: https://github.com/ximion/appstream/issues/243

AFAICT just removing the <extends>QXmlEdit.desktop</extends> should fix this.

lbellonda commented 5 years ago

You are right. The current specifications do not allow the "extends" tag and some other tag needs an update. I file this issue for the next release due in a couple of month at maximum. Do you are able to apply a patch in the meantime?

Vogtinator commented 5 years ago

For now we applied a patch to AppStream to not crash, so for now it just rejects QXmlEdit (as it should).

lbellonda commented 5 years ago

An updated appInfo has been pushed to "194-invalid_metadata" branch. May you test it? Please note that it references the .desktop file in "launchable" tag.

Thank you.

Vogtinator commented 5 years ago

Unfortunately I do not know how to test the .xml file, but

> appstreamcli validate QXmlEdit.appdata.xml 
Validation was successful: pedantic: 1

so it seems good.

lbellonda commented 4 years ago

Published a fix in 0.9.14.