search

lbellonda / qxmledit

QXmlEdit XML editor. Downloads: https://sourceforge.net/projects/qxmledit/files
http://qxmledit.org
Other
160 stars 46 forks source link

Fixed Linux metadata getting installed into incorrect folders #84

Closed Mailaender closed 1 year ago

Mailaender commented 2 years ago

I am working on a package for @flathub and this had to be corrected. See also this workaround at https://build.opensuse.org/package/view_file/editors/qxmledit/qxmledit.spec

lbellonda commented 2 years ago

Hello, changing these files could break installation scripts on some distro. A new release is underway so please be patient, I will look into this issue after the upcoming release.

Mailaender commented 2 years ago

I used the legacy /usr/share/appdata folder, which should exist even on older distros. Not taking this will likely continue to break more distributions.

lgbaldoni commented 2 years ago

@lbellonda I received your email: unfortunately I no longer have time to maintain the package, but perhaps @Mailaender would like to?

Mailaender commented 2 years ago

I am a bit annoyed why my patch was not merged prior to release. Couldn't answer you via e-Mail because G-Mail rejected it as unsolicited. I also don't think we should open up another communication channel on the mailing list.

Mailaender commented 2 years ago

Shall I rebase this?

lbellonda commented 2 years ago

Hello, the release was ready to ship, I did not want to touch the package with a last minute modification. The mail was to open a discussion for all the interested maintainers. Please, do not rebase, I am already porting the changes and writing tests to validate them, however the master branch is not for new features, but only for releases. The new features are forked and merged into the “devel” branch. I will close the issue when tests are done.

lbellonda commented 2 years ago

If you need to test installation folders without waiting for the compilation of the whole project, you can set the environment variable QXMLEDIT_USE_FAKE_SOURCES to any value as written in INSTALL file.

Mailaender commented 2 years ago

https://github.com/flathub/org.qxmledit.QXmlEdit/pull/1 now fails and I have to rebase this. Do you still want to reject the patch?

lbellonda commented 2 years ago

Hi, give me a few days to look into this issue.

Mailaender commented 2 years ago

Rebased. Do I need to make the installation optional like the icon? I have never seen anyone do it.

lbellonda commented 2 years ago

Hello, some note about the commit:

  1. the branch to use as reference is “devel”. Master is only for releases and no development is done directly on master,
  2. new installation options need unit testing, I will update the testing files,
  3. new installation options need to be discussed in the mailing list for the benefit of maintainer of other distribution, even non Linux-based.

Let me check the commit, discuss and integrate the changes. Right now I have not much time, but I will work the issue asap.

lbellonda commented 2 years ago

Hello, the variations have been committed on devel branch and are ready for next release. The default values are the same of the other items,but are configurable via command line or environment variables. See the INSTALL file for details.