search

lbenz730 / ncaahoopR

An R package for working with NCAA Basketball Play-by-Play Data
MIT License
198 stars 48 forks source link

assist_net not getting every Assist #105

Closed jrbarber37 closed 1 year ago

jrbarber37 commented 1 year ago

The assist_net function appears to be missing assists. As an example, for the championship (gameId=401522202), UConn had 13 assists, but only 4 assists were shown in the Assist Net.

Another example, for gameId= 401522201, UConn had 19 assists, but only 5 assists were shown in the Assist Net.

In the example on the website (gameId= 401522201, Oklahoma - Kansas, January 23, 2019), Assist Net correctly captures Oklahoma's 14 assists.

I have the most recent version of ncaahoopR - devtools::install_github("lbenz730/ncaahoopR")

lbenz730 commented 1 year ago

Thanks for alerting me. May be a few days before i can look into it...

jrbarber37 commented 1 year ago

Thank you for your response. Please let me know if you need any more information.

John

On Fri, Sep 8, 2023 at 3:20 PM Luke Benz @.***> wrote:

Thanks for alerting me. May be a few days before i can look into it...

— Reply to this email directly, view it on GitHub https://github.com/lbenz730/ncaahoopR/issues/105#issuecomment-1712121976, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUIJZH5Z6X6NC3QDYYU5GODXZNVWRANCNFSM6AAAAAA4QYOSQI . You are receiving this because you authored the thread.Message ID: @.***>

jrbarber37 commented 1 year ago

assist_net appears to not get all assists only for the 2022-23 season. Also, the following code: assist_net(team = "Yale", node_col = "royalblue4", season = "2022-23") gets the following error: Play-by-Play Data Not Available for Assist Network assist_net(team = "Yale", node_col = "royalblue4", season = "2021-22") works as expected.

lbenz730 commented 1 year ago

Both issues now fixed in latest development version. Thanks for alerting me and let me know if you run into any other issues.

jrbarber37 commented 1 year ago

This is all working great for me now. Thanks!

John Barber

On Mon, Sep 11, 2023 at 9:39 AM Luke Benz @.***> wrote:

Both issues now fixed in latest development version. Thanks for alerting me and let me know if you run into any other issues.

— Reply to this email directly, view it on GitHub https://github.com/lbenz730/ncaahoopR/issues/105#issuecomment-1713904347, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUIJZHY3XLAHPHK5N3NRXFLXZ4H7TANCNFSM6AAAAAA4QYOSQI . You are receiving this because you authored the thread.Message ID: @.***>