lbenz730 / ncaahoopR

An R package for working with NCAA Basketball Play-by-Play Data
MIT License
198 stars 48 forks source link

2023-24 Rosters #114

Closed vigslayer closed 10 months ago

vigslayer commented 10 months ago

Been consistently getting these errors when trying to pull rosters this year. Is this an issue on ESPN's side?

"Unable to get roster. ESPN is updating CBB files. Check back again soon."

Full code below. Not an urgent issue at all since I can get roster info from boxscores but this would help double check things.

Thanks! Mike

image
lbenz730 commented 10 months ago

Should be working fine in latest version of the package. Just make sure you have that installed.

vigslayer commented 10 months ago

Checked I was up to date on the hoopR version and re-ran. Still getting this error. Something else I'm doing wrong?

image
lbenz730 commented 10 months ago

Ah i see the issue. ids[team_i, 1] is a df not a charafter. Do it like this

library(ncaahoopR)

loopmatrix <- 1:nrow(ids)

for(team_i in loopmatrix) {
  team_roster <- get_roster(ids$team[team_i], '2023-24')
  ...
}
vigslayer commented 10 months ago

That fixed the issue. Weird that my code worked for old seasons but not 2023. Thanks Luke!