lbenz730 / ncaahoopR

An R package for working with NCAA Basketball Play-by-Play Data
MIT License
198 stars 48 forks source link

Score on 1st possession not updated until next play (when there is no jump ball data) #117

Closed CBBHooper closed 9 months ago

CBBHooper commented 9 months ago

See in example 1 how the score doesn't reflect the first bucket

cbbexample2

But in example 2 it does

cbbexample3

Seems that it affects every game without jump-ball data, where there is also a score on the first play

lbenz730 commented 9 months ago

Thanks for bringing to my attention. I will see if I can get a fix deployed this week.

lbenz730 commented 9 months ago

This is now fixed in the latest version. Just re-install and let me know if it persists.

CBBHooper commented 9 months ago

Thank you! Does not seem to have fixed all instances though. See this example

cbbexample4

lbenz730 commented 9 months ago

Ah sorry I made a typo. It's now fixed for real.