search

lbfm-rwth / GaussParallel

https://lbfm-rwth.github.io/GaussParallel/
GNU General Public License v2.0
2 stars 5 forks source link

Get rid of `IsHPC` in `DoEchelonTransformationMatBlockwise` or maybe rename it #159

Open ssiccha opened 5 years ago

ssiccha commented 5 years ago

~IsHPC kind of sounds like IsHPCGAP although for now we also want to use the variable IsHPC in GAP to tell it to use the parallel code path.~

emmakatherina commented 5 years ago

I don't really understand what you mean. Changing IsHPC to UseHPC sounds good to me. Do we want to change it in Chief, too?

ssiccha commented 5 years ago

Yeah, I didn't write my thoughts up clearly. What I meant is: We use, what is now called IsHPC, to tell the algorithm whether to use the parallel or the sequential code path. I suggested to rename that variable to UseHPC.

Now that I think about it though, I think we should postpone this issue until we're done with milestone 0.2. It may well happen that after 0.2 we get rid of IsHPC completely. Then there's no need to rename that variable in all our *.g and *.tst files.

ssiccha commented 5 years ago

Now that we have changed the implementation we can't use a sequential version of this algorithm in HPC-GAP anymore. At least not without jumping through some hoops. So let's remove this parameter.