Closed jnkbrachter closed 5 years ago
Also please add a test for the new feature
Merging #238 into master will decrease coverage by
1.17%
. The diff coverage is73.07%
.
@@ Coverage Diff @@
## master #238 +/- ##
==========================================
- Coverage 91.47% 90.29% -1.18%
==========================================
Files 16 16
Lines 1993 2041 +48
==========================================
+ Hits 1823 1843 +20
- Misses 170 198 +28
Impacted Files | Coverage Δ | |
---|---|---|
gap/main.gi | 90.55% <39.39%> (-6.4%) |
:arrow_down: |
gap/utils.g | 94.04% <97.77%> (-5.26%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 365f954...65259ae. Read the comment docs.
Can we easily do this without duplicating code in ChopMatrix? I suggest a new function. Something like: PrepareChopDatastructure.