search

lbfm-rwth / GaussParallel

https://lbfm-rwth.github.io/GaussParallel/
GNU General Public License v2.0
2 stars 5 forks source link

Fix block size #248

Closed emmakatherina closed 3 years ago

emmakatherina commented 5 years ago

Our help function GAUSS_calculateBlocks in gap/utils.g is now used to calculate the block size in DoEchelonMatTransformationBlockwise.

Please merge.

codecov-io commented 5 years ago

Codecov Report

Merging #248 into master will increase coverage by 0.18%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #248      +/-   ##
==========================================
+ Coverage   90.57%   90.76%   +0.18%     
==========================================
  Files          17       17              
  Lines        2070     2079       +9     
==========================================
+ Hits         1875     1887      +12     
+ Misses        195      192       -3
Impacted Files Coverage Δ
gap/main.gi 90.34% <100%> (ø) :arrow_up:
PackageInfo.g 95.06% <0%> (-1.28%) :arrow_down:
gap/utils.g 98.79% <0%> (+4.81%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 79182c5...3242850. Read the comment docs.

ssiccha commented 5 years ago

If you don't want to extend the test suite systematically please add an issue to remind us that we still need to do that.

jnkbrachter commented 3 years ago

We arrived at the conclusion that this feature is no longer needed.