search

lbitonti / liquibase-hana

Liquibase Hana extension
Apache License 2.0
11 stars 11 forks source link

Support for VARBINARY data type #9

Closed aamotharald closed 6 years ago

aamotharald commented 7 years ago

Hi Luigi, Hi Matthew,

can I get write access to the repository so that I can add the VARBINARY data type support? I have wwritten a liquibase.datatype.ext.VarbinaryTypeHanaDB and changed liquibase.datatype.ext.BlobTypeHanaDB to ignore VARBINARYs

lbitonti commented 7 years ago

Hi Harald,

Can you please create a pull request if you have changes you want to get included?

Thanks, Luigi

aamotharald commented 7 years ago

Hi Luigi,

I am not sure if I have understood this procedure. I have created a local branch and would like to push it so I can create a pull request with this branch.

But I am not allowed to push to the repo. Can you give me the rights to push to the repo? Otherwise I cannot create a pull request.

Best regards,

Harald

From: Luigi Bitonti [mailto:notifications@github.com] Sent: Mittwoch, 29. März 2017 13:59 To: lbitonti/liquibase-hana liquibase-hana@noreply.github.com Cc: Aamot, Harald harald.aamot@sap.com; Author author@noreply.github.com Subject: Re: [lbitonti/liquibase-hana] Support for VARBINARY data type (#9)

Hi Harald,

Can you please create a pull request if you have changes you want to get included?

Thanks, Luigi

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/lbitonti/liquibase-hana/issues/9#issuecomment-290067986, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAI-dYD32YccVsP5frSYnRG3QB5KCf6Fks5rqkeFgaJpZM4MrPlS.

aamotharald commented 7 years ago

I now have now forked and created a pull request. Hope this works..

aamotharald commented 6 years ago

Hi Luigi,

thanks for merging. Closing the issue.

lbitonti commented 6 years ago

Thank you Harald. I've just made a 3.1.1 release which includes your PR.

Cheers, Luigi