search

lbittarello / Microeconometrics.jl

Microeconometric estimation in Julia
Other
30 stars 11 forks source link

use formula macro for statsmodels v0.2.4 compatibility #6

Closed kleinschmidt closed 6 years ago

kleinschmidt commented 6 years ago

StatsModels v0.2.4 moves parsing of formula expressions into the @formula macro. As a result, calling the Formula constructor directly is discouraged since it doesn't expand things like *. This change doens't affect the tests for this package but I've updated it nevertheless since it could produce unexpected behavior for users. You might consider adding tests for more complicated formulae (at least testing things like ~ 1+a*b).

kleinschmidt commented 6 years ago

Also this change should be backwards compatible with older versions of StatsModels, so I didn't update the REQUIRES.

lbittarello commented 6 years ago

Thanks for fixing it!