search

lbl-anp / becquerel

Becquerel is a Python package for analyzing nuclear spectroscopic measurements.
Other
44 stars 16 forks source link

Version v0.4.2 and pre-commit rules/CI integration #289

Closed jccurtis closed 3 years ago

jccurtis commented 3 years ago

@cosama this should fix the CD issues with multiple versions and adds some pre-commit checking which will make @micahfolsom smile 😄

cosama commented 3 years ago

I am just wondering is it sufficient to just build a single python wheel for all of these different versions/platforms? How does pypi decide that? I like the precommit stuff.

jccurtis commented 3 years ago

The dist is determined by the wheel command:

https://github.com/lbl-anp/becquerel/blob/main/.github/workflows/pypi.yaml#L32

which is currently set to dist and makes a .whl which is python3 minor version and OS and arch independent. There is a nice write-up of this I just read on medium.

Previously we released with python setup.py bdist ... (ref) which is outdated.

jccurtis commented 3 years ago

Also I updated the release docs to reflect the new CD process.

jccurtis commented 3 years ago

@cosama @jvavrek @markbandstra any thoughts?

jvavrek commented 3 years ago

@jccurtis to confirm, this only restricts the CD to one python version? Not the testing?

jccurtis commented 3 years ago

@jccurtis to confirm, this only restricts the CD to one python version? Not the testing?

Yes! That is correct 😄