Closed markbandstra closed 2 years ago
Also fixes #309. Ready for review.
I still kind of think that the default domain and range should be unbounded, especially given that the domain
is really only used for validation and default plot x values. But that's maybe for another time.
Not sure how to clear the "changes requested" status of this PR given that I have resolved all of the issues flagged by @jvavrek ...
Not sure how to clear the "changes requested" status of this PR given that I have resolved all of the issues flagged by @jvavrek ...
I think I just had to hit Approve. Send it! 🚀
Fixes #314. Now a warning is raised when a
Calibration
function yields values outside its specified range. For example:Yields:
The warning is raised but no longer are the values themselves clipped to the range as this has led to various problems.