search

lbl-anp / becquerel

Becquerel is a Python package for analyzing nuclear spectroscopic measurements.
Other
43 stars 16 forks source link

peakfinder: reset found peaks before looking for new peaks. Fixes #352 #353

Closed arunpersaud closed 1 year ago

arunpersaud commented 2 years ago

without this changing the min_snr to a higher value did not change the found peaks.

cosama commented 1 year ago

@markbandstra Any idea what is up with these tests. They seem unrelated, all fail in:

FAILED tests/isotope_qty_test.py::test_isotopequantity_from_comparison[K-40]
FAILED tests/isotope_qty_test.py::test_isotopequantity_from_comparison[Th-232]
FAILED tests/isotope_qty_test.py::test_decay_normalize[K-40] - assert False
FAILED tests/isotope_qty_test.py::test_decay_normalize[Th-232] - assert False
FAILED tests/isotope_qty_test.py::test_decay_normalize_spectra[K-40] - assert...
FAILED tests/isotope_qty_test.py::test_decay_normalize_spectra[Th-232] - asse...
markbandstra commented 1 year ago

@markbandstra Any idea what is up with these tests. They seem unrelated, all fail in:

FAILED tests/isotope_qty_test.py::test_isotopequantity_from_comparison[K-40]
FAILED tests/isotope_qty_test.py::test_isotopequantity_from_comparison[Th-232]
FAILED tests/isotope_qty_test.py::test_decay_normalize[K-40] - assert False
FAILED tests/isotope_qty_test.py::test_decay_normalize[Th-232] - assert False
FAILED tests/isotope_qty_test.py::test_decay_normalize_spectra[K-40] - assert...
FAILED tests/isotope_qty_test.py::test_decay_normalize_spectra[Th-232] - asse...

No idea, I'm rerunning the tests.