search

lbl-anp / becquerel

Becquerel is a Python package for analyzing nuclear spectroscopic measurements.
Other
43 stars 16 forks source link

add Fitter.param_rel_unc and adjust pandas append to concat #368

Closed jvavrek closed 1 year ago

jvavrek commented 1 year ago

Convenience function for fit parameter relative uncertainty

jvavrek commented 1 year ago

Only the 3.7 jobs are passing. Everything else gives

ERROR tests/isotope_qty_test.py::test_isotopequantity_from_comparison[Tl-208] - AttributeError: 'DataFrame' object has no attribute 'append'

Is the pandas dependency out of date?

jvavrek commented 1 year ago

Locally with Python 3.9.13 all tests pass, but I do see the warning:

tests/wallet_cache_test.py::TestWalletCardCache::test_fetch
  /Users/jvavrek/becquerel/becquerel/tools/wallet_cache.py:64: FutureWarning: The frame.append method is deprecated and will be removed from pandas in a future version. Use pandas.concat instead.
    self.df = self.df.append(df_chunk)

pandas 2.0 is being installed on the python 3.8+ builds vs v1.3.5 on python 3.7 vs my local v1.5.1.

Deprecating append for concat was a controversial decision.

jvavrek commented 1 year ago

@markbandstra all pipelines passed!