search

lbl-anp / becquerel

Becquerel is a Python package for analyzing nuclear spectroscopic measurements.
Other
43 stars 16 forks source link

Bump python versions #375

Closed jvavrek closed 1 year ago

jvavrek commented 1 year ago

Python 3.7 has reached end-of-life: https://devguide.python.org/versions/

jvavrek commented 1 year ago

The CI still seems to be expecting 3.7 tests despite having removed it from workflows/tests.yaml. Maybe there's a cache or something? I think this probably ready either way though.

jvavrek commented 1 year ago

@markbandstra you may have to force merge here. We had the same problem eight months ago.

markbandstra commented 1 year ago

Merged, hopefully that works. Just noticed that we need to update the badge in the README that shows the python versions next time.

jvavrek commented 1 year ago

For future reference, we needed to edit the required checks in the branch protection rules settings.

markbandstra commented 1 year ago

Also for future reference, to update the python versions badge, we actually need to edit the __metadata__.py file and release it to PyPI, since the badge looks to PyPI for that information.