search

lbl-cbg / t5-commons

Code required for the Taskforce5 commons project.
1 stars 0 forks source link

production docker files #9

Closed yonglbl closed 1 month ago

yonglbl commented 3 months ago

the original docker-compose didn't really point to the builded react files , react/build

dsclassen commented 3 months ago

Can you please add static/ to the .gitignore file in backend

...and what is making it?

dsclassen commented 3 months ago

I pushed a few edits needed for me to run docker compose -f docker-compose.prod.yml build

dsclassen commented 3 months ago

I still get this error:

=> ERROR [react-prod build 7/7] RUN npm run build                                                                                                                                                            41.4s
------                                                                                                                                                                                                              
 > [react-prod build 7/7] RUN npm run build:                                                                                                                                                                        
0.457                                                                                                                                                                                                               
0.457 > frontend@0.1.0 build                                                                                                                                                                                        
0.457 > craco build                                                                                                                                                                                                 
0.457 
1.793 Creating an optimized production build...
4.811 One of your dependencies, babel-preset-react-app, is importing the
4.811 "@babel/plugin-proposal-private-property-in-object" package without
4.811 declaring it in its dependencies. This is currently working because
4.811 "@babel/plugin-proposal-private-property-in-object" is already in your
4.811 node_modules folder for unrelated reasons, but it may break at any time.
4.811 
4.811 babel-preset-react-app is part of the create-react-app project, which
4.811 is not maintianed anymore. It is thus unlikely that this bug will
4.811 ever be fixed. Add "@babel/plugin-proposal-private-property-in-object" to
4.811 your devDependencies to work around this error. This will make this message
4.811 go away.
4.811   
41.19 Failed to compile.
41.19 
41.19 [eslint] 
41.19 src/Species.js
41.19   Line 137:28:  'viewState' is not defined  no-undef
41.19 
41.19 Search for the keywords to learn more about each error.
41.19 
41.19 
------
failed to solve: process "/bin/sh -c npm run build" did not complete successfully: exit code: 1
dsclassen commented 3 months ago

Did you see my notes about CORS in https://github.com/lbl-cbg/t5-commons/issues/3#issuecomment-2174441876 I think we will need to configure both nginx and other components to properly pass modified headers.... or something along those lines.

yonglbl commented 3 months ago

will do

dsclassen commented 3 months ago

this seems to be working

dsclassen commented 3 months ago

Apparently now that I am the author of the most recent commit I am unable to "Review" the PR.

dsclassen commented 1 month ago

Someone please merge this into main

yonglbl commented 1 month ago

@ajtritt @oruebel can you approve the merge?