lbl-srg / ctrl-flow-dev

ctrl-flow development
Other
0 stars 0 forks source link

Incompatibility with MBL master #365

Closed AntoineGautier closed 2 months ago

AntoineGautier commented 7 months ago

Through https://github.com/lbl-srg/ctrl-flow-dev/pull/358 it was detected that the current version of the app is not compatible with MBL master, at least from commit https://github.com/lbl-srg/modelica-buildings/tree/3185e8f328 where the first version of the Templates package was merged.

Some class names in Guideline 36-2021 (mappings).csv are obsolete. All component interface classes must be modified from Buildings.Templates.(AirHandlersFans|ZoneEquipment).Components.*.Interfaces to Buildings.Templates.(AirHandlersFans|ZoneEquipment).Components.Interfaces.*.

✅ Tests show that fixing class names within the mapping file solves the issue. The exported SOO document then contains the appropriate sections related to OA & RA dampers.

Capture d’écran 2023-10-18 à 14 13 07
AntoineGautier commented 6 months ago

Through https://github.com/lbl-srg/modelica-buildings/pull/3531, some class names used in Guideline 36-2021 (mappings).csv have been modified:

AntoineGautier commented 2 months ago

Addressed with #370