search

lbl-srg / ctrl-flow-dev

ctrl-flow development
Other
0 stars 0 forks source link

Updated production site deployment workflow #368

Closed JayHuLBL closed 6 months ago

JayHuLBL commented 7 months ago

This closes #366.

Description

AntoineGautier commented 7 months ago

@JayHuLBL There is an issue on the current staging branch, see https://github.com/lbl-srg/ctrl-flow-dev/issues/360#issuecomment-1772326895. I am adding a patch on MBL via https://github.com/lbl-srg/modelica-buildings/pull/3566 and updating MBL commit hash via #369.

Also, I noticed that the order of the systems at https://staging.ctrl-flow.lbl.gov/#/systems is not the same as the one I have locally (AHU before zone equipment). Can you look into that?

AntoineGautier commented 6 months ago

@JayHuLBL There is still an issue with the current staging branch, which shall not be merged yet. The sections pertaining to relief damper control (w/o fan) are not included in the exported documentation. This is likely due to what I described at https://github.com/lbl-srg/ctrl-flow-dev/issues/365#issuecomment-1793769766.

AntoineGautier commented 6 months ago

@JayHuLBL I checked the documentation export with the following AHU options:

The documents generated by the staging and main versions are identical. This is ready to merge on my end.

JayHuLBL commented 6 months ago

@AntoineGautier Thanks for the review. I will merge it.