search

lbl-srg / modelica-buildings

Modelica Buildings library
249 stars 155 forks source link

Steam District Heating - Networks #2904

Open khinkelman opened 2 years ago

khinkelman commented 2 years ago

@bravache: Could you please create a new branch from the master for this issue at your earliest convenience? These new models are not dependent on any existing open branches.

This issue is to add the steam district heating models to the DHC.Networks.Steam package, as previously agreed upon (green highlighted area in the image below). This work is part of the URBANopt project, and the merging is time sensitive in order to submit the paper "Towards Open-Source Modelica Models for Steam-Based District Heating Systems" to the 1st International workshop on "Open Source Modelling and Simulation of Energy Systems", with a final submission deadline of March 10, 2022.

[Update] The Steam.Loads will also be added with this PR because of dependencies with the DistributionNetwork model. image

Model Descriptions These network models follow the same structure as the existing DHC.Networks models developed by @AntoineGautier. However, they have been customized for steam systems that use the split-medium approach (as described in (Preprint) Hinkelman et al. 2022, Energy.). The base classes allow users to replace the pipe models in Connection2Pipe and Distribution2Pipe with alternates while retaining compatible interfaces among all models in the DHC.Networks package.

If you have any further questions, please let me know. Many thanks!

@SaranyaAnbarasu: cc'ing you so you are aware and can track.

JayHuLBL commented 2 years ago

@khinkelman @bravache I just created the new branch issue2904_steamnetwork for the development.

khinkelman commented 2 years ago

Many thanks!

bravache commented 2 years ago

@JayHuLBL @khinkelman Sorry for the delay, thanks Jianjun for taking care of that!

khinkelman commented 2 years ago

The current steam network models include lossless pipes on the steam supply side. Thus, the steam distribution network model example is structurally singular for open-loop examples with mass flow and/or pressure states declared at the network boundaries. To keep with the original example model implemented, the BuildingTimeSeries model and its SteamTrap base class will be added to this PR. The green shaded region above has been adjusted accordingly.

khinkelman commented 2 years ago

Hi @bravache: This issue is ready for review but contains dependencies on PR #2701. Should I go ahead and open the PR for this issue so that it is ready when you/your team are ready? Or would you prefer I wait until PR #2701 is merged with the master (and the updates can then seamlessly be pulled across to this branch). Thanks for your input!

bravache commented 2 years ago

Well, this has already been merged to lbl-srg. I might create another branch to pull everything bit by bit though. This way we can have a PR for the changes that are specific to this, and also merge everything to master together. Does that make sense?

khinkelman commented 2 years ago

Yes, that makes sense. I'll open the PR for this issue now so that we can see the changes and keep moving everything forward bit by bit. Thanks again for your help!