search

lbl-srg / modelica-buildings

Modelica Buildings library
257 stars 159 forks source link

Fixed issue when multiple sims are performed for models including FFD #3995

Closed chria closed 2 months ago

chria commented 2 months ago

If multiple simulations are performed for a model that includes FFD without fully releasing the library, then the second simulation would fail due to that the global structure "cosim" has not been set to NULL in the destructor. The use case can be for instance when the model is compiled into an FMU and the following is performed:

  1. Load the FMU
  2. Simulate
  3. Use the FMI reset method
  4. Simulate again (will fail)

An example model is Buildings.ThermalZones.Detailed.Examples.FFD.ForcedConvection)

Setting the structure "cosim" to NULL will resolve the issue.

mwetter commented 2 months ago

@chria : Thanks for catching this, I will also apply it to the maintenance branches.

chria commented 2 months ago

Great! Thanks @mwetter